Generated Links in Email Signatures displayed correct, linked wrong

olsn · September 11, 2021, 9:46am

Infos:

Used Zammad version: 4.1.x
Used Zammad installation type: package
Operating system:
Browser + version: Chrome Version 93.0.4577.63

Expected behavior:

A http link should refer to what is written in it.

Actual behavior:

Link in signature editor looks like this: https://abc.com/kundenzufriedenheit/123456/1a2b3d/!pi#{ticket.number}
Link in used signature looks like: https://abc.com/kundenzufriedenheit/123456/1a2b3d/!pi1234 (displayed correct)
The real URL of the generated link is this: https://abc.com/kundenzufriedenheit/123456/1a2b3d/!pi#%7Bticket.number%7D
it seems that the { and } converted into %7B and %7D so the variable are not working anymore

Steps to reproduce the behavior:

Try to add a #{ticket.number} variable at the end of a link in signatures. Use any possible way like copying from notepad (text only), remove hyperlinks (ctrl+alt+x), insert with no formatting (ctrl+alt+v), insert from Word or Outlook including html formatting. All this ways doestn work for us.
Referring to Generated links in signature are strange - also not working for us.

MrGeneration · September 21, 2021, 4:14pm

Just for completeness - the following issue affects above behavior:

github.com/zammad/zammad

Signatures sanitize variables in URLs

opened 09:21AM - 21 Sep 21 UTC

MrGeneration

bug ticket verified prioritised by payment

### Infos: * Used Zammad version: 4.1/stable * Installation method (source, package, ..): any * Operating system: any * Database + version: any * Elasticsearch version: any * Browser + version: verified on Google Chrome & Thunderbird * Ticket: #1092157 ### Expected behavior: Using variables within URLs in signatures is no problem if you insert them correctly. ### Actual behavior: Zammad sanitizes correct inserted URL to death upon saving the signature. *Note: This does not affect e.g. trigger based emails* ### Steps to reproduce the behavior: * update any signature of your choice and insert the following URL without formatting (CTRL+SHIFT+V) `https://example.com/kundenzufriedenheit/123456/1a2b3d/!pi=#{ticket.number}` * save the signature * go to any ticket and hit reply and check the signature - the link already is broken: ``` <a href="https://example.com/kundenzufriedenheit/123456/1a2b3d/!pi=#%7Bticket.number%7D" title="https://example.com/kundenzufriedenheit/123456/1a2b3d/!pi=71005" rel="nofollow noreferrer noopener" target="_blank">https://example.com/kundenzufriedenheit/123456/1a2b3d/!pi=71005 </a> * double tab in the signature section (it's broken there as well) I also checked rails console level - this is how Zammad saves it into the database ``` Yes I'm sure this is a bug and no feature request or a general question.

system · January 19, 2022, 4:15pm

This topic was automatically closed 120 days after the last reply. New replies are no longer allowed.