CSS suggests orange border means it is internal:
.is-internal .internal-border {
background: repeating-linear-gradient(45deg, hsl(18,79%,89%), hsl(18,79%,89%) 5px, hsl(210,17%,98%) 5px, hsl(210,17%,98%) 6px);
background-size: 8px 8px;
}
But how does the user/agent learn/remember this? it would be nice if a popup said “this note is internal” when they hovered over the border.
the lock/unlock icon is to change state, and it always shows the target state (ie if you click, it will change to…)
so if you don’t know what the orange border means, the lock icon might make you think it is currently locked (ie think that the icon represents current state).
also, its very difficult to tell the difference between a locked and unlocked padlock unless you zoom in, [brainstorming follows…] so i’d prefer completely different icons for the 2 states (eg a trumpet for public?)
maybe better would be a pair of icons (a big one showing the current state, and a smaller one you click to toggle)? or mousover text which says clearly “currently, private, click to make public”. The present mouseover text is too terse, and the user might wonder what to make of it.