Appointment preview > download file

germeshausen · May 9, 2023, 8:18pm

Probably a small change request which can improve usability a bit in specific circumstances.
If in a appointment preview the file for the download has no file extension, zammad should fall back to handle it as a ics-file therefore a manual renaming of the file to open it with the the default application would be obsolete.

We have seen this behavior in Teams appointments which results in a file with no extension while trying to download it.

Mirtaaa · August 16, 2023, 8:03am

We couldn’t follow 100% so we would like to make sure, could you please confirm that this is what you mean?

You get an appointment invitation from MS Teams like this

And when you press download file it will be downloaded without the .ics extension so you have to rename it before you can open it in your calendar app. Your suggestion is, that it will be downloaded directly with the .ics extension so that it opens directly in your calendar app?

Mirtaaa · August 16, 2023, 8:06am

for internal/developer note:

In case, to replace “file” with “appointment.ics” we just need to extend the line 844

github.com

zammad/zammad/blob/develop/app/models/channel/email_parser.rb#L844


      
          
          if !filename.force_encoding('UTF-8').valid_encoding?
            filename = filename.utf8_encode(fallback: :read_as_sanitized_binary)
          end
          
          # generate file name based on content-id with file extention
          if filename.blank? && headers_store['Content-ID'].present? && headers_store['Content-ID'] =~ %r{(.+?\..{2,6})@.+?}i
            filename = $1
          end
          
          # e. g. Content-Type: video/quicktime
          if filename.blank? && (content_type = headers_store['Content-Type'])
            map = {
              'message/delivery-status': %w[txt delivery-status],
              'text/plain':              %w[txt document],
              'text/html':               %w[html document],
              'video/quicktime':         %w[mov video],
              'image/jpeg':              %w[jpg image],
              'image/jpg':               %w[jpg image],
              'image/png':               %w[png image],
              'image/gif':               %w[gif image],

with the follwoing:
‘text/calendar’: %w[ics appointment],

germeshausen · August 16, 2023, 8:26pm

Yes, that is exactly what I meant.