[WIP] fix missing variables in trigger body content

ping!

Anyone?

@anon29869905

Hey guys, I know you are busy but this PR is ready to go and Id love to get it into main :slight_smile:

and avoid having to build a custom image in the mean time; however am prepared to do so

ping? anyone; sorry i know its irritating thanks for your time

Thorsten and I are on vacation this week.
We’ll have to ask for a bit more patience until Thorsten managed to catch up his back log starting next week. :slight_smile:

Hey no problem! sorry to push! Now I know you guys are on holiday its no issue!

Maybe can update profile status flair/whatever to indicate vacation (like slack) :palm_tree:

Have a great break

Hope you guys are back and have had a good rest! I hope that you will be able to get time to review soon @MrGeneration @anon29869905

Hey @rosscdh. I’m back and wanted to let you know that I probably won’t find the time to review your change this week. I’ll let you known once I got feedback.

Welcome back, no probs! thanks for the note

please dont forget @anon29869905

1 Like

Next week is freeze for the upcoming version and I’m busy with finishing and reviewing the main feature changed and additions. That’s why I didn’t found and won’t find the time to work on your contribution. However, I asked @rolfschmidt to help me out and he will work on it from now. We expect to get it done/merged by end of the week so that it will be part of the upcoming version. Thanks for your understanding.

Grand mate! @rolfschmidt just did the merging!

Really pleased you took it! and I look forward to being able to use it in prod.

2 Likes

So finally 3.6 went stable and is now available by the docker-compose images!

I’m happy to say that my contribution has now allowed me to integrate on triggers with a small signing/payment processor.

A pity the change is not mentioned in the 3.6 release notes as it is a fairly useful fix.

1 Like

Thank you for your efforts @rosscdh!

1 Like

Oh boy!
Sorry! Really - I noticed colleguales already to have a look.

I think we should be able to put the relevant info into the release notes later than never.

Again sorry, that was not the plan!

2 Likes

Ah great to hear! sorry i dont mean to make a fuss. Thanks for the update

Hey @rosscdh - sorry for the delay and not making our gratitude clear enough. Thank you for your contribution! I was a bit in a hurry because of working on the website relaunch, new Zammad release and first issue of our newsletter simultaneously. TBH @rolfschmidt did all the work on our side here. So thanks again to the both of you.

I can understand your disappointment that this useful fix is not part of the Release Notes. However, we don’t mention bugfixes in the Release Notes. The Release Notes are only a short overview of the major features that we added in this release. This time the great WebHooks contribution, the Archive Mailbox functionality and the Microsoft 365 authentication compatibility enhancement.
However, adding information about the many other changes (47 bugfixes and enhancements!) would blow up the release notes and make it unreadable. That’s why we link to the Changelog which contains your fix.

Anyhow. Would you mind sharing how you think we can improve this from your perspective (while keeping the Release Notes readable)?

Off Topic: We still have some Zammad T-Shirts in Stock. If you’re interested in getting one just send me a direct message with your size and and address and I’ll check if we have one. I’ll send it to you or keep you on the list once we order the next batch.

1 Like

Hi Thorsten! Really not an issue mate! I appreciate the feedback tho! Hell yes ill take the T-shirt please!
Great product happy to advertise my use of it! And even more happy to have contributed to it.