Confusion about LDAP attributes login & email

MrGeneration · April 8, 2019, 10:34am

Hey,

sorry for the delay!
I had this on a workshop recently as well in a fairly big LDAP with loads of custom attributes and a lot information filled in. So in that case (and proberbly yours as well), you’re running in a hardcoded attribute limit, which doesn’t give you all attributes or rather proberbly the wrong ones.

Normally, Zammad would also suggest to map mail to email within Zammad, but sometimes, above reason strikes. You can overcome that hardcoded limit -normally temporary is enough for doing so- (during configuration), but I want to talk about this in the team anyway, because I feel the limit is too low.

Open /opt/zammad/lib/ldap/user.rb in a editor of your choice, go to line 140 and change break if lookup_counter >= 50 to break if lookup_counter >= 500 or higher. You might need to fiddle until you have all the fields you need for selection / mapping.

github.com

zammad/zammad/blob/develop/lib/ldap/user.rb#L140


@ldap.search(custom_filter || filter, base: base_dn) do |entry|
  pre_merge_count = attributes.count


  attributes.reverse_merge!(entry.to_h
                                 .except(*BLACKLISTED)
                                 .transform_values(&:first)
                                 .compact)


  # check max 50 entries with the same attributes in a row
  lookup_counter = (pre_merge_count < attributes.count ? 0 : lookup_counter.next)
  break if lookup_counter >= 50
end


# format sample values for presentation
attributes.each do |name, value|
  attributes[name] = if value.encoding == Encoding.find('ascii-8bit')
                       "#{name} (binary data)"
                     else
                       "#{name} (e.g., #{value.utf8_encode})"
                     end
end

Note: A restart of services is not required, but you’ll need to reopen the LDAP configuration process. Adding a new field to the mapping will fix the issue and afterwards do it’s job as expected.

I hope that helps.