"Client storage" - does this option actually do anything?

Infos:

  • Used Zammad version: 2.9.x
  • Used Zammad installation source: docker-compose
  • Operating system: Debian 9
  • Browser + version: Chromium

I’m curious about this option:

Admin -> Settings -> System -> Frontend

Option: Client storage
Description: Use client storage to cache data to enhance performance of application.
Allowed values: yes/no
Default: no

I enabled this because it sounds like it would make Zammad faster, but I also wondered if it might have any negative effects. I searched through the code, but it doesn’t look like it’s actually used anywhere:

zammad@martin.mein-iserv.de ~ (develop) % ag --nopager -i 'ui_client_storage' .
db/migrate/20170123000002_fixed_translation.rb
39:        'name'        => 'ui_client_storage',

db/seeds/settings.rb
590:  name:        'ui_client_storage',
598:        name:    'ui_client_storage',

If I’m grepping correctly, the usage of this option was removed with this commit:

commit 4a9c2c55b2ef46b3e0d49a158fb79ebb4306c256
Author: Martin Edenhofer <me@edenhofer.de>
Date:   Tue Nov 3 19:36:24 2015 +0100

    Removed storage options from collection helper.

Looks like it’s superfluous and should be removed :slight_smile:

Personally I never experienced any difference. It’s supposed to use more of the Browsers caching and thus improve your experience when having slower connections to your Zammad-Server.

I think @thorsteneckel can give a better clue here. :slight_smile:

I agree :blush: A PR would be awesome!

This topic was automatically closed 120 days after the last reply. New replies are no longer allowed.